stitchfix / stitchfix.github.io

15 stars 4 forks source link

DRY up the team #37

Closed yorthehunter closed 10 years ago

yorthehunter commented 10 years ago

Goal: Make it very easy to add new team members (or teams) in the future

The Changes: Instead of copying and pasting the markup and directly changing it there, you can now add (or move or remove) team members by changing a bit of YAML in a file called teams.yml

Background: On a whim, I decided to try and DRY up the code used to display the team and its members.

I used YAML as accessible custom data in Jekyll to hold information about each person on the team. It's presented in the view using the same bits of markup and some Liquid templating.

Everything to see is in the code and I'm open to suggestions.

NOTE: I tried my best to keep everyone's information the same and even tested all of the links, but I may have made a mistake here or there.

Example: teams_yml_-_stitchfix_github_io_-____work_stitchfix_stitchfix_github_io_

jonathandean commented 10 years ago

neat!

ndp commented 10 years ago

good stuff. Although now we'll have to find a new hazing ritual for new pledges. :-(

pdudek commented 10 years ago

This is very cool Brian!

yorthehunter commented 10 years ago

I was under the impression that all new employees must be able to quote from Big Trouble in Little China before they even get a phone interview...

Also TODO: I think this change would necessitate a brief set of directions in the readme, but I was waiting to see if there's any changes we should make here beforehand.

davetron5000 commented 10 years ago

:+1: to this! I hate copy/pasting all that HTML

simeonwillbanks commented 10 years ago

:100: