New Layout - Githubissues

stitchfix / stitchfix.github.io

15 stars 4 forks source link

Closed leobalter closed 9 years ago

leobalter commented 9 years ago

in order to finish there are some small tasks to assure this PR is ok:

[ ] verify team members pics on the Engineering and Algorithms pages
[ ] clear out the example post on engineering/_posts/ using a categorized post with a team member data.
[ ] fill the job locations with real data, the current data is just used as example. The files are located at _jobs/*.md.

davetron5000 commented 9 years ago

@leobalter are you looking for comments/feedback, or is this just a step toward launch?

leobalter commented 9 years ago

this is just a step forward launch, but comments and feedback would be helpful.

davetron5000 commented 9 years ago

This doesn't incorporate any of the changes based on my latest round of feedback. Should I re-post here, or would you prefer email?

Also, are these the final “hero” images? They load very slowly when I'm running locally

aaronsbrown commented 9 years ago

@davetron5000

Just FYI, our contract with Bocoup is up, so they won't be making any more changes. We'll be doing them in-house when Eli is back.

These aren't the final hero images, just placeholders. I'm guessing these images are full-res, unoptimized.

Can you add your latest round of feedback here just to capture it (i never saw it).

Thanks, Aaron

davetron5000 commented 9 years ago

OK, good to know. We should probably take this offline, as this repo is public.

I'll start an email chain.

davetron5000 commented 9 years ago

I've copied this over to a private repo so we can discuss in GH, but not in public.

davetron5000 commented 9 years ago

Closing this as we have the code in another repo as we get ready for go-live

ndp commented 9 years ago

Hi, are new people supposed to add themselves to a different repo? If so, which one?

davetron5000 commented 9 years ago

I'll email eng with the deets