search

stjohnjohnson / smartthings-mqtt-bridge

Bridge between SmartThings and MQTT
https://hub.docker.com/r/stjohnjohnson/smartthings-mqtt-bridge/
MIT License
363 stars 241 forks source link

Huge refactor of the SmartApp - SUPPORTS EVERY CAPABILITY #22

Closed stjohnjohnson closed 8 years ago

stjohnjohnson commented 8 years ago

Things to note:

stjohnjohnson commented 8 years ago

/cc @joelash FYI, here's the refactor I was thinking

joelash commented 8 years ago

:+1: This is about what I wanted to do! Thanks for beating me to it.

I assume there would still be changes required similar to the branch I was working on to keep the armed states of an HA alarm_control_panel with SmartThings Smart Home Monitor?

stjohnjohnson commented 8 years ago

@joelash Sorry for the delay, so for your Smart Home Monitor PR, I'd love it if you could create an issue here and we can walk through the design. I sadly haven't played with either HA's alarm or SmartThings monitor tool. But I think you'll either need to continue to modify the bridge device type or make another custom device type that can support that back and forth communication via the SmartApp.

jer commented 8 years ago

:+1: huge change, but it reads a lot simpler despite the support for everything.

What does it do to the SmartApp UI?

stjohnjohnson commented 8 years ago

It is slow to load (I'm assuming it has to evaluate the code first) but then you get TONS of options. On Tue, Mar 8, 2016 at 22:38 Jeremiah Wuenschel notifications@github.com wrote:

[image: :+1:] huge change, but it reads a lot simpler despite the support for everything.

What does it do to the SmartApp UI?

— Reply to this email directly or view it on GitHub https://github.com/stjohnjohnson/smartthings-mqtt-bridge/pull/22#issuecomment-194140283 .

-St. John

jer commented 8 years ago

I vote :shipit: but there may need to be an improvement later that lets us categorize stuff into pages or something