stjude-dnb-binfcore / sc-rna-seq-snap

BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Add module for fastqc-analysis #11

Closed AntoniaChroni closed 3 days ago

AntoniaChroni commented 1 week ago

Purpose/implementation Section

The current PR adds files to run the fastqc-analysis module as it is.

  1. lsf-script.txt file on how to run the bash run-fastqc-analysis.sh file on lsf
  2. README file: documentation on how to run the module
  3. run-fastqc-analysis.sh file: to run the module on an interactive session

What GitHub issue does your pull request address?

Closes #10.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Please run both:

Instructions on how to run these files can be found on README file.

Which areas should receive a particularly close look?

Please also confirm the following:

AntoniaChroni commented 1 week ago

@sharonfreshour I have also updated the README file on the main repo to reflect recent changes. See 7fb98474df749b955a186a2ef5d32716da39edfb

AntoniaChroni commented 3 days ago

-Small note, there is a .DS_Store hidden file in analyses/fastqc_analysis folder

Thank you for noticing! This has been taken care of now. See f993f23502b34206233d61d92bd754a67ae2276b

AntoniaChroni commented 3 days ago

Everything looks good.

I made one note about the file path for the run-fastqc-analysis.sh, not sure if that needs to be addressed now or later

Fixed here da126639ad42241321c0f2d32b5f2aef1c4ccfc8