Closed AntoniaChroni closed 3 days ago
@sharonfreshour I have also updated the README
file on the main repo to reflect recent changes. See 7fb98474df749b955a186a2ef5d32716da39edfb
-Small note, there is a .DS_Store hidden file in analyses/fastqc_analysis folder
Thank you for noticing! This has been taken care of now. See f993f23502b34206233d61d92bd754a67ae2276b
Everything looks good.
I made one note about the file path for the run-fastqc-analysis.sh, not sure if that needs to be addressed now or later
Fixed here da126639ad42241321c0f2d32b5f2aef1c4ccfc8
Purpose/implementation Section
The current PR adds files to run the
fastqc-analysis
module as it is.lsf-script.txt
file on how to run the bashrun-fastqc-analysis.sh
file on lsfREADME
file: documentation on how to run the modulerun-fastqc-analysis.sh
file: to run the module on an interactive sessionWhat GitHub issue does your pull request address?
Closes #10.
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Please run both:
run-fastqc-analysis.sh
andlsf-script.txt
files separately to ensure both options run smoothly and confirm that they do.Instructions on how to run these files can be found on
README
file.Which areas should receive a particularly close look?
Please also confirm the following:
README
file contains enough clear documentation on running the module..results/01-fastqc-reports
with all expected files..results/02-multiqc-reports
with all expected files..results/multiqc_report.html
with all expected files.run-fastqc-analysis.sh
file for clarity.lsf-script.txt
file for clarity and efficiently using resources.