search

stjude-rust-labs / fq

Command line utility for manipulating Illumina-generated FASTQ files.
MIT License
77 stars 5 forks source link

Version reporting not working #20

Closed rorynolan closed 3 years ago

rorynolan commented 3 years ago

Using the version installed via cargo install --git https://github.com/stjude/fqlib.git --tag v0.7.0 I cannot get the program to report its version. Running fq lint -V I only get fq-lint as output with no version info. I'm on Mac Big Sur 11.6.

zaeleus commented 3 years ago

Thanks for the report, @rorynolan! This is fixed in 0.7.1.

rorynolan commented 3 years ago

I have a different problem now @zaeleus The version isn't reporting correctly.

Screen Shot 2021-10-08 at 4 39 58 PM

The commit hash is the right one but the version number is missing.

zaeleus commented 3 years ago

I'll have to investigate this further. It seems cargo is cloning the repository in an unexpected manner. In the interim, clone the repository manually and install from the project path.

$ git clone https://github.com/stjude/fqlib.git
$ cd fqlib
$ git switch --detach v0.7.1
$ cargo install --force --path .
$ fq --version
fq v0.7.1 (869b59271 2021-10-07)
$ fq lint --version
fq-lint v0.7.1 (869b59271 2021-10-07)
zaeleus commented 3 years ago

cargo does not fetch tags, which is how the version is determined at build time. I updated the manual install instructions in the readme to clone the repo first.

rorynolan commented 3 years ago

FWIW the regular cargo install on linux does report version correctly.