search

stjude-rust-labs / wdl

Rust crates for working with Workflow Description Language (WDL) documents.
Apache License 2.0
26 stars 6 forks source link

New RedundantAssignment rule #189

Open a-frantz opened 1 month ago

a-frantz commented 1 month ago

Upgrading discussion #105 to an issue for visibility. See the linked discussion for more details, but any conversation about this rule should occur here.

michaelgattas commented 4 weeks ago

@a-frantz I'm happy to take this one on!

a-frantz commented 4 weeks ago

@michaelgattas all yours!

I wasn't explicit about this small complication, but this rule is going to need to check the version of the document, and only fire if the version is >=v1.1 (i.e. this should be silent in 1.0 documents). There are examples of other rules checking the version, so you can just follow those examples (missing_runtime.rs is one of those examples).

michaelgattas commented 2 weeks ago

@a-frantz do you think this should this create a Warning or Note diagnostic?

a-frantz commented 2 weeks ago

@a-frantz do you think this should this create a Warning or Note diagnostic?

I think this is note territory. The more verbose syntax isn't a source of confusion.