stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.
https://proteinpaint.stjude.org/
Other
16 stars 3 forks source link

Independent zooming on both sides of the 2 chr subpanel hic track view not consistent #1097

Open creilly8 opened 8 months ago

creilly8 commented 8 months ago

The zoom in and out buttons in the control panel primarily work on the left subpanel. To recreate:

  1. Go to https://proteinpaint.stjude.org/?appcard=hic and click on the 2 chr example.
  2. Click on In in the control bar above the genome browser. Notice the left side changes every time but the right side scale at the top remains the same and partially zooms in. The bottom right corner does not update on click.

This video shows these steps and the result: https://github.com/stjude/proteinpaint/assets/20135430/7a73a752-beb0-4ba3-899d-51275338a91e

Here's another example from a v9 demo file that's less problematic, available from: https://proteinpaint.stjude.org/?genome=hg38&hicfile=proteinpaint_demo/hg38/hic/hic_demo_v9.hic&enzyme=MboI.

https://github.com/stjude/proteinpaint/assets/20135430/38be3841-8bb2-4b6d-ad03-335958021490

Suggested solution: Add buttons for both sides so users may zoom each subpanel independently.

xzhou82 commented 8 months ago

on hovering over In or Out buttons, a tooltip appears on top. you have to click the tooltip option to zoom in/out on the 2nd panel

On Thu, Jan 4, 2024 at 3:20 PM Colleen Reilly @.***> wrote:

The zoom in and out buttons in the control panel primarily work on the left subpanel. To recreate:

  1. Go to https://proteinpaint.stjude.org/?appcard=hic and click on the 2 chr example.
  2. Click on In in the control bar above the genome browser. Notice the left side changes every time but the right side scale at the top remains the same and partially zooms in. The bottom right corner does not update on click.

This video shows these steps and the result:

https://github.com/stjude/proteinpaint/assets/20135430/7a73a752-beb0-4ba3-899d-51275338a91e

Here's another example from a v9 demo file that's less problematic, available from: https://proteinpaint.stjude.org/?genome=hg38&hicfile=proteinpaint_demo/hg38/hic/hic_demo_v9.hic&enzyme=MboI .

https://github.com/stjude/proteinpaint/assets/20135430/38be3841-8bb2-4b6d-ad03-335958021490

Suggested solution: Add buttons for both sides so users may zoom each subpanel independently.

— Reply to this email directly, view it on GitHub https://github.com/stjude/proteinpaint/issues/1097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMLJJPLUX2HHIMSJ6DNUVTYM4MLRAVCNFSM6AAAAABBNQ5REOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DMMZVGEYDMMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

creilly8 commented 8 months ago

@xzhou82 That's good to know. Then we just need to fix it so the zoom only applies to that panel and the rendering problem described above. No need to add extra buttons and whatnot.

xzhou82 commented 8 months ago

this ui control may not be intuitive. small measure of improvement is to add a brief note in the Two chr panel of https://proteinpaint.stjude.org/?appcard=hic please go do it

xzhou82 commented 8 months ago

likely there's bug in calculating and using bp/frag resolution in the 2-chr view