stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.
https://proteinpaint.stjude.org/
Other
18 stars 5 forks source link

do not call niceNumLabels() on integer term density/violin #1723

Closed creilly8 closed 3 months ago

creilly8 commented 3 months ago

Description

Addresses issue #1716.

Changes:

  1. Do not pass decimals from the violin when the term type is integer.
  2. New unit test and file specifically for tvs.density
  3. Filter pill only shows rounded numbers

Test with:

  1. Edit violin in the control panel and filter. Also brush the plot -> Add filter -> Filter in navigation -> only rounded numbers.
  2. Other violin render plots: Age at dx from sample label
  3. Unit tests

Checklist

Check each task that has been performed or verified to be not applicable.

xzhou82 commented 3 months ago

related issue. from integer violin, select range and "Add to filter", then the tvs pill will contain decimal.

creilly8 commented 3 months ago

related issue. from integer violin, select range and "Add to filter", then the tvs pill will contain decimal.

Fixed in https://github.com/stjude/proteinpaint/pull/1723/commits/89ae6b457d9432fd0e998a6ff43bbdb806c4fe74

airenzp commented 3 months ago

Thanks for the fixes and the tests. Seems on the right track. Now the integer handling is restored.