search

stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.
https://proteinpaint.stjude.org/
Other
13 stars 3 forks source link

Extract setHeaders method. #1732

Closed aacic closed 2 weeks ago

aacic commented 3 weeks ago

Description

This is a draft pull request, we need to analyze it before merging it.

Checklist

Check each task that has been performed or verified to be not applicable.

siosonel commented 2 weeks ago

Tested to make sure that the express.static() middleware does not require its own setHeaders() function, that the middleware before it that sets the headers is sufficient, and it looks like that's what's happening.

I tested by:

  1. Creating a "test" string value for Access-Control-Allow-Origin in app.middleware.js Screenshot 2024-06-20 at 1 39 34 PM

  2. In Chrome dev tools Networks tab, this response header matches the test value Screenshot 2024-06-20 at 12 59 15 PM

Pending test of file:///Users/esioson/dev/sjpp/proteinpaint/public/index.html: errors only show up when clicking on cards, where the hostURL has been set to use window.location.origin