stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.
https://proteinpaint.stjude.org/
Other
13 stars 3 forks source link

fix: getFilterName() treats geneExp and metabolite same as float terms #1738

Closed xzhou82 closed 2 weeks ago

xzhou82 commented 2 weeks ago

Description

now a standalone function, with unit tests http://localhost:3000/testrun.html?dir=mds3&name=filterName.unit

test with dictionary term filtering works on non-gdc and gdc tracks

however, unable to test gene exp filter for non-gdc track, due to unknown error possibly at data loading (seems no variants are loaded), and unrelated to this change

Checklist

Check each task that has been performed or verified to be not applicable.

karishma-gangwani commented 2 weeks ago

I am seeing a failing test.

not ok 1 loading of all import(spec) timed out after 5000ms

xzhou82 commented 2 weeks ago

you need to kill and restart npm run dev. there's some issue with that when switching branches