stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.
https://proteinpaint.stjude.org/
Other
13 stars 3 forks source link

"scatter" toggle of summary chart is not tested #1754

Closed xzhou82 closed 1 week ago

xzhou82 commented 1 week ago

when both term1 and term2 are numerical, summary chart should display 3 tabs: bar/violin/scatter

quick fix would be around line 350 of mass/test/summary.integration.spec.js requiring toggles.find(scatter) is true in agedx/hrtavg combination

also if possible to identify summary chart code of this logic and isolate it, and make unit test

as we introduce more non-dict variables that are continuous in nature, it's important that summary is able to show "scatter" option in all suitable conditions