Show citation for survivorship portal in dataset button.

stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.

https://proteinpaint.stjude.org/

Other

14 stars 3 forks source link

Show citation for survivorship portal in dataset button. #1809

Closed creilly8 closed 3 weeks ago

creilly8 commented 3 weeks ago

Description

Added missing citation button to survivorship sandbox. Test with http://localhost:3000/?appcard=survivorBtn

Checklist

Check each task that has been performed or verified to be not applicable.

[x] Tests: added and/or passed unit and integration tests, or N/A
[x] Todos: commented or documented, or N/A
[x] Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

gavrielm commented 3 weeks ago

If I open http://localhost:3000/?appcard=survivorBtn and then X out of the app and then click on the Survivorship Study button, the Citation button seems to be missing.

xzhou82 commented 3 weeks ago

sorry missed Gav's comment. please fix it

creilly8 commented 3 weeks ago

If I open http://localhost:3000/?appcard=survivorBtn and then X out of the app and then click on the Survivorship Study button, the Citation button seems to be missing.

The host for changes from localhost to https://survivorship.proteinpaint.stjude.org when the portal is launched below the intro and saved in sessionStorage during dofetch. It doesn't revert back to localhost on subsequent requests. The reason it fails is because the cars/survivorBtn.json on https://survivorship.proteinpaint.stjude.org doesn't include the citation_id.

@xzhou82 I think this can be solved in a different PR.