matrix: enable Edit option for geneVariant rows

stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.

https://proteinpaint.stjude.org/

Other

14 stars 3 forks source link

matrix: enable Edit option for geneVariant rows #1822

Closed congyu-lu closed 2 weeks ago

congyu-lu commented 3 weeks ago

Description

Checklist

Check each task that has been performed or verified to be not applicable.

[x] Tests: added and/or passed unit and integration tests, or N/A
[x] Todos: commented or documented, or N/A
[x] Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

xzhou82 commented 2 weeks ago

when a term is grouped, matrix can render grouped data, but hover over a cell breaks. test with termdbtest matrix

matrix.interactivity.js:158 Uncaught TypeError: Cannot read properties of undefined (reading 'label')

it's not simply enabling the option in matrix. it has to work with matrix

xzhou82 commented 2 weeks ago

thanks the tooltip hover over grouped geneVariant row now works however, at customizing a group it breaks. try with termdbtest map, click TP53, at its default group, drag Frameshift to 2nd group and apply, gets this err. please assess. thanks

TypeError: Cannot read properties of undefined (reading 'groups') at matrix.groups.js:277:29 at Array.filter ()