show variable name upon selection in tvs submenu

stjude / proteinpaint

Data visualization and analysis framework focused on phenotype-molecular data integration at cohort level.

https://proteinpaint.stjude.org/

Other

19 stars 5 forks source link

show variable name upon selection in tvs submenu #1862

Closed karishma-gangwani closed 3 months ago

karishma-gangwani commented 3 months ago

Description

now variable name shows on selection for custom variable

Checklist

Check each task that has been performed or verified to be not applicable.

[x] Tests: added and/or passed unit and integration tests, or N/A
[x] Todos: commented or documented, or N/A
[x] Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

xzhou82 commented 3 months ago

how to test?

karishma-gangwani commented 3 months ago

how to test?

If you create groups by selecting variables and click on the blue pill for editing the categories within the variable selected you should see a text showing term.id for that variable in the tvs submenu

xzhou82 commented 3 months ago

just replace the bold Select 1 or more sentense with the variable name

karishma-gangwani commented 3 months ago

just replace the bold Select 1 or more sentense with the variable name

okay I made the change. can you test now?

xzhou82 commented 3 months ago

rebase on master
confirm if tvs/filter tests all pass
revert notify.ts changes if they are accidental

karishma-gangwani commented 3 months ago

rebase on master

confirm if tvs/filter tests all pass

revert notify.ts changes if they are accidental

okay rebased and reverted the change. all tests pass.