stkb / Rewrap

Rewrap extension for VSCode and Visual Studio
https://marketplace.visualstudio.com/items/stkb.rewrap
Other
499 stars 58 forks source link

Release 17.7 Pre-Release as main published version? #391

Open karlhorky opened 7 months ago

karlhorky commented 7 months ago

Hi @stkb, thanks so much for making Rewrap!

What do you think about republishing the 17.7 Pre-Release (from 2022) as the main released version?

It has great features like onSave, which many users would benefit from.

lumoe commented 5 months ago

Using the pre-relase for a while now, especially for the onSave feature. Looks stable to me, would appreciate releasing it as the main released version as well.

Thank you for your time and work, @stkb

rdsedmundo commented 5 months ago

The onSave doesn't work well for code comments. I realize it may be challenging to distinguish, but it's quite common to comment a whole block for testing purposes, and it's rewrapping everything as of now.

Before:

await transaction.rollback(
      { status: 'pending' },
      null,
      { transaction: sqlTransaction },
      /*hint*/ true,
      /*immediate*/ false,
      /*delegated*/ true,
    );

Then I comment the whole block using a selection + CMD /:

    // await transaction.rollback(
    //   { status: 'pending' },
    //   null,
    //   { transaction: sqlTransaction },
    //   /*hint*/ true,
    //   /*immediate*/ false,
    //   /*delegated*/ true,
    // );

Upon saving it becomes:

    // await transaction.rollback( { status: 'pending' }, null, { transaction: sqlTransaction }, /*hint*/ true,
    //   /*immediate*/ false, /*delegated*/ true, );
karlhorky commented 5 months ago

@rdsedmundo workaround:

Add Markdown code fences / code block delimiters (three back ticks, like this: ```) above + below the code in your comments (and make sure your commented code doesn't have any uncommented lines)