fix option upgrade routine

[stklcode]

Upgrading options without changes utilizes array_merge_recursive() to merge (potentially updated) default settings with current options.

With something like

[
  'active' => 1,
  ...
]

and default

[
  'active' => 1,
  ...
]

this results in

[
  'active' => [ 0, 1 ],
  ...
]

Because we have custom routines in place for 1.4 and 1.6 and we skipped 1.5 this was not a real issue. Noticed when updating the version to 1.7 without option changes.

Replace the merge function by array_replace_recursive() resolves the issue for now.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication