search

stla / EllipticFunctions.jl

Jacobi theta functions and related functions.
https://stla.github.io/EllipticFunctions.jl/dev/
MIT License
15 stars 4 forks source link

Fix nome tests #21

Closed simonp0420 closed 1 year ago

simonp0420 commented 1 year ago

Most of the problems were in the tests themselves, but there were also a couple of problems in the code.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (nome@23c911b). Click here to learn what that means. Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## nome #21 +/- ## ======================================= Coverage ? 81.73% ======================================= Files ? 1 Lines ? 646 Branches ? 0 ======================================= Hits ? 528 Misses ? 118 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stla commented 1 year ago

Thanks!!

kagalenko-m-b commented 1 year ago

Maybe, it's time to make this a registered package?

stla commented 1 year ago

Thanks both. My Linux laptop is broken. Now I only have an old laptop with Windows 7 and my work laptop with Windows 10. Will try to install Julia portable.

simonp0420 commented 1 year ago

Sorry to hear about your hardware troubles.