Open stla opened 1 year ago
Ah I've just had a thought. In the new _jtheta1dash0
, there is a call to the generalized Jacobi theta function with a value 1/6
. Maybe we should promote the type of 1/6
to the extended precision.
Yes, perfect. I've done 1/(6*one(tau))
and the test is successful!
Would you know how to update the documentation? The page has been last deployed on July 2022. I don't remember how to trigger the update.
Looking at the log of one of your old successful documentation runs I see this:
Hmm... would you know where should I add this label?
I see that in the YAML file:
docs:
name: Documentation
runs-on: ubuntu-latest
if: "contains( github.event.pull_request.labels.*.name, 'preview docs') || github.ref == 'refs/heads/master' || contains(github.ref, 'refs/tags/')"
......
So if I push on master, that should generate the doc?
The action is triggered but it is finished after 0 second. I'm lost.
Sorry, those files are black magic to me as well. Maybe ask on Discourse.
Already asked on Discourse :) I also tried to update the YAML file, with no luck.
I've finally managed! The doc is at https://stla.github.io/EllipticFunctions.jl/dev/ (not at https://stla.github.io/EllipticFunctions.jl/)
@simonp0420 , @kagalenko-m-b
I've just pushed a new version.
_jtheta1dash0
, the derivative at0
of the first Jacobi theta functionThe third point has caused a problem: the test of the theta-S Neville function with extended precision has failed, because of a small imaginary part in the result while this result should be a real number. I added
atol = 1e-15
in@approx
in order that the test succeeded.