search

stlab / adobe-contract-checks

Contract checking facilities for C++
Boost Software License 1.0
6 stars 0 forks source link

Fixing CI issues #1

Closed sean-parent closed 1 month ago

sean-parent commented 2 months ago

Creating PR to test CI fix.

dabrahams commented 2 months ago

I won't kibitz further after this but it looks like you might be trying to do too many things at once and the scope of the PR is too large. The things that should eventually be pruned aren't causing the failures in the main branch, but removing them can cause failures. I would start by just getting the tests to pass, and do that in one PR, then prune in followup PRs. If you're confident this is going to work out, feel free to ignore me of course.

sean-parent commented 2 months ago

One of the Windows builds was failing to compile libfmt, and the only catch2 test was failing on some platforms (hypothesis was that it may be a problem with throwing across a dll boundary since those tests also build catch2 as a dll). So simplifying. I've made some progress but a bit stuck. One thing I'm seeing locally is an interaction with WILL_FAIL YES and PASS_REGULAR_EXPRESSION on the abort tests. I tried _Exit(EXIT_SUCCESS) in the handler but that still counts as a failure.

dabrahams commented 2 months ago

hypothesis was that it may be a problem with throwing across a dll boundary since those tests also build catch2 as a dll

Don't we want to make everything work if you throw across a dll boundary?

One thing I'm seeing locally is an interaction with WILL_FAIL YES and PASS_REGULAR_EXPRESSION on the abort tests.

That interaction, from my experiments, is that WILL_FAIL YES inverts the sense of PASS_ and FAIL_. Thus this code. Note that the PASS_REGULAR_EXPRESSION is the un-expected pattern.

dabrahams commented 1 month ago

Closing as obsolete. @sean-parent feel free to reopen.