search

stlab / libraries

ASL libraries will be migrated here in the stlab namespace, new libraries will be created here.
https://stlab.cc
Boost Software License 1.0
661 stars 65 forks source link

namespace version bump #541

Closed sean-parent closed 7 months ago

sean-parent commented 7 months ago

Bumping the inline namespace version to v2 to avoid ODR violations. The pre_exit code remains at v1 (it must be bumped more carefully). The portable default executor is moving to v2 - which may lead to more than one thread pool for the portable instance. Pinning the version here is more difficult. Removed dead reset() operations in future shared_base Documented (and assert) precondition that future::exception() is only invoked on a ready exception. Made more of the tuple meta-facilities public to avoid detail:: namespace usage in unit tests. Restructured unit tests to avoid sleep-wait-loops.

fosterbrereton commented 7 months ago

Change LGTM, with a minor nit. Thank you Sean for keeping on top of this issue!