search

stleamist / BetterSafariView

A better way to present a SFSafariViewController or start a ASWebAuthenticationSession in SwiftUI.
MIT License
581 stars 57 forks source link

Allows presenting SFSafariViewController when the rootViewController is already presenting another view controller #9

Closed boherna closed 3 years ago

boherna commented 3 years ago

The main commit fixes the issue reported at https://github.com/stleamist/BetterSafariView/issues/8

The other commit fixes a weird case (difficult to replicate) when dismissSafariViewController is called but uiViewController is not presenting.

OrkhanAlikhanov commented 3 years ago

Thank you, this worked. Specified your last commit 04e067b9a29fc634138e761d36028d22eb5bb41c in xcode when adding the package

stleamist commented 3 years ago

Hi Bohdan,

Thank you for creating the first pull request on this repository. I really appreciate your work on fixing this issue!

This improvement will be available in v2.3.1 shortly :)

boherna commented 3 years ago

Thanks for accepting the pull request. Happy to contribute. Thank YOU for sharing SFSafariViewController!