search

stleary / JSON-Java-unit-test

Junit test harness to validate the JSON-Java GitHub project code.
Apache License 2.0
28 stars 45 forks source link

Improving opt test to include missing values #54

Closed quidryan closed 8 years ago

quidryan commented 8 years ago

Proves out https://github.com/stleary/JSON-java/issues/260

stleary commented 8 years ago

Will consider after the revert is completed. Thanks again for catching it.

quidryan commented 8 years ago

I wasn't following the previous work that had to be reverted, but wouldn't this test be relevant irrelevant to the state of the JSON-Java repo? This add coverage which did not exist before.

stleary commented 8 years ago

Well, the tests are not even included in the Maven repo. We keep them release-synced, so there is always a test release to match the JSON release, but there is no requirement for them to be timestamp-synced, if we are rushed. Since @johnjaylward has also made a pull request in #55, we will proceed there. Please take a look at that branch and post if you see any tests that should be added.

johnjaylward commented 8 years ago

@quidryan , I basically did the same as you, but extended the tests to cover more opt methods in #55

I believe my PR has more coverage than your even though we took the same approach. Let me know if you see anything else that needs to be added.