search

stleary / JSON-java

A reference implementation of a JSON package in Java.
http://stleary.github.io/JSON-java/index.html
Other
4.54k stars 2.56k forks source link

Migrating to Junit 5 #847 #848

Closed anudeepikamunnangi closed 10 months ago

anudeepikamunnangi commented 10 months ago

I made changes required for the Junit 5 migration. Please review and accept the changes.

stleary commented 10 months ago

@anudeepikamunnangi Thanks, but this PR cannot be accepted at this time. Even if the upgrade to Junit 5 goes forward, we will initially need to keep the same unit tests.

anudeepikamunnangi commented 10 months ago

@stleary, I didn't changed change any testcases.I just restructured all testcases to junit 5.The way we handled temporal file ,parameterized test and exceptional handling is different. https://www.baeldung.com/parameterized-tests-junit-5 https://www.baeldung.com/junit-5-migration