search

stlehmann / pyads

Python wrapper for TwinCAT ADS
MIT License
255 stars 94 forks source link

Use GitHub actions for CI #211

Closed pylipp closed 3 years ago

pylipp commented 3 years ago

Are there any objections against using GitHub actions for CI? It's faster than travis (which queues test suites for quite some time) and a native part of the code hosting platform. Also travis changed it's pricing model last fall, so OS projects have less free build minutes.

With GitHub actions it's straight forward to run both Python tests, and even publish a package automatically to PyPI (not sure if @stlehmann currently manually publishes them?). The config for a side project of mine is here. If desired I'll copy and adjust it for pyads.

stlehmann commented 3 years ago

Are there any objections against using GitHub actions for CI?

Actually my only objection is that I know Travis CI well and have been working with it for a long while now. I haven't used github actions so far.

With GitHub actions it's straight forward to run both Python tests, and even publish a package automatically to PyPI (not sure if @stlehmann currently manually publishes them?)

Automatic publishing on PyPi sounds like a nice feature. Indeed I do the upload manually since the beginning of time.

The config for a side project of mine is here. If desired I'll copy and adjust it for pyads.

If you like you can make a PR to setup CI on Github Actions. This way we can run both CIs in parallel and eventually change to Github if it performs better.

stlehmann commented 3 years ago

@pylipp Thanks for the bump towards Github Actions. I introduced them with #221. Also Upload to PyPi should happen automatically on release.