Closed stlehmann closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pyads/pyads_ex.py | 42 | 45 | 93.33% | ||
<!-- | Total: | 43 | 46 | 93.48% | --> |
Totals | |
---|---|
Change from base Build 1439873570: | 0.2% |
Covered Lines: | 1663 |
Relevant Lines: | 1766 |
Looks like there needs to be some more effort here. Strings are handled special in read and write functions. So that needs to be applied to WSTRINGS as well.
Now we also need some testing.
I just made a Wireshark dump to see if the WSTRING is null-terminated with 1 or 2 Bytes:
Clearly it is two bytes null-termination. So the testserver has to resemble this behaviour.
Hi @stlehmann
i have an equipement with WSTRING, i try next week this PR
Regards,
I just have a use-case where I use WSTRINGs and discovered that adsSumRead and adsSumWrite also need specific WSTRING support
Tested the implementation on my PC but couldn't get the test-cases pass, yet. Somehow the encoding is not right. Suggestions are welcome 😊
@kryskool did you already do some testing on your setup with this branch?
Todo: handle WSTRINGS right in adsSyncReadWriteReqEx2 and in adsSyncWriteControlReqEx
Addresses #246