refactoring - Githubissues

stm32-community / stm32-enc28j60

An ENC28J60 (cheap ethernet module) library for STM32 projects

62 stars 26 forks source link

refactoring #7

Closed mykola2312 closed 9 months ago

mykola2312 commented 9 months ago

Hello,

While researching and trying to understand how does this library work I stumbled upon a lot of messy and ugly code, so this PR aimed to fix this.

Changes I have made so far:

Make more CMake configuration variables that I forgot in last PR
Make multi MCU support (see CMake variables)
Replace memory-copying loops with memcpy/memset/etc. If you don't link with libc/newlib I believe it's easy to implement memcpy/memset functions by yourself
Formatting and indentation

It has been tested and works fine, if there is any bug left I will fix it soon

Best regards,

xaionaro commented 9 months ago

Nice, thanks!

Just in case, feel free to accept next PRs and merge them yourself :)