Fix LCD timings for F746G disco example

stm32-rs / stm32f7xx-hal

A Rust embedded-hal HAL for all MCUs in the STM32 F7 family

Apache License 2.0

115 stars 67 forks source link

Fix LCD timings for F746G disco example #106

Closed mchodzikiewicz closed 3 years ago

mchodzikiewicz commented 3 years ago

This PR fixes https://github.com/stm32-rs/stm32f7xx-hal/issues/105

mchodzikiewicz commented 3 years ago

btw, timings are adjusted according to official ST example: https://github.com/STMicroelectronics/STM32CubeF7/tree/master/Drivers/BSP/STM32746G-Discovery

hannobraun commented 3 years ago

I haven't used this feature, nor do I have the hardware to test it. @grodino, it seems you added that code, any thoughts?

grodino commented 3 years ago

@mchodzikiewicz The values I used were taken from an Application Note from ST and worked for me but if this is from the official example, I'm fine with this too ;) @hannobraun I do not have the hardware anymore so I can't test it sorry

hannobraun commented 3 years ago

Okay then, since it works for @mchodzikiewicz and nobody objects, I'm merging. Thank you @mchodzikiewicz and @grodino!

mchodzikiewicz commented 3 years ago

great! What I can tell is that my two boards are from different hw revisions (B-02 and B-04) and both of them did not worked and started working after this adjustment