search

stm32-rs / stm32f7xx-hal

A Rust embedded-hal HAL for all MCUs in the STM32 F7 family
Apache License 2.0
117 stars 68 forks source link

Fix a bunch of Clippy warnings (and errors) #130

Closed hannobraun closed 3 years ago

hannobraun commented 3 years ago

This pull request bundles a large number of low-impact changes to fix most Clippy warnings (and errors). Together with #128 and #129, this should fix the Clippy portion of the CI build.

dtjones190 commented 3 years ago

I reviewed and agree that these changes should all be functionally identical. In commit b4ba44f , is appending "_f32" to specify the type preferred over appending a ".0"?

hannobraun commented 3 years ago

Thank you for reviewing, @dtjones190!

In commit b4ba44f , is appending "_f32" to specify the type preferred over appending a ".0"?

I just followed Clippy's recommendation without really questioning it. I thought that maybe .0 would cause a type inference issue, but didn't test that.

@mvertescher Any objections to merging this?

mvertescher commented 3 years ago

Awesome, fixes look good