Fix mass-erase trigger on "small" devices.

stm32-rs / stm32f7xx-hal

A Rust embedded-hal HAL for all MCUs in the STM32 F7 family

Apache License 2.0

114 stars 65 forks source link

Fix mass-erase trigger on "small" devices. #210

Closed BryanKadzban closed 4 months ago

BryanKadzban commented 4 months ago

The list of specifically enumerated "large" devices has the correct set of register operations to start a mass erase, setting the mer1 and mer2 bits. But the "small-devices" alternative does not; it clears the mer bit instead of setting it.

Looking at history, this was changed from set to clear in the PR that added support for "large" devices. It appears to have been accidental.

BryanKadzban commented 4 months ago

The CI tests are failing due to the nightly compiler change to reject all references to mutable statics, not due to this change.

BryanKadzban commented 4 months ago

Could you add an entry to the changelog about this?

Done.

Could you also add the couple of addr_of_mut! calls so that the nightly compiler is happy? (this does not need a changelog entry)

Also done.

Thanks!