stm32-rs / stm32g0xx-hal

Peripheral access API for STM32G0 series microcontrollers
Apache License 2.0
73 stars 51 forks source link

Spelling error `dma_circualr_mode()` #143

Open dauntown opened 7 months ago

dauntown commented 7 months ago
pub trait DmaMode<ADC> {
    /// Error type returned by ADC methods
    type Error;
    fn dma_enable(&mut self, enable: bool);
    fn dma_circualr_mode(&mut self, enable: bool);   // <=======
}

Here DmaMode contains the method dma_circualr_mode(). Please correct it to dma_circular_mode(). The name error doesn't inspire confidence it will in fact work.

As seen on https://github.com/stm32-rs/stm32g0xx-hal/blob/e6145ef83c639e736556fb4775f349aef7100ad6/src/analog/adc.rs#L374C16-L374C16

Disasm commented 7 months ago

Thanks! Would you like to create a PR to fix the typo?

dauntown commented 7 months ago

No thanks, the honor, and the breaking change, is all yours.