search

stm32-rs / stm32l0xx-hal

A hardware abstraction layer (HAL) for the STM32L0 series microcontrollers written in Rust
BSD Zero Clause License
96 stars 60 forks source link

Clippy CI build fails #163

Closed hannobraun closed 3 years ago

hannobraun commented 3 years ago

The Clippy CI build currently fails, presumably because a new Clippy version has been pulled in. It would be nice to get this fixed (either by following what Clippy says or by silencing those warnings; haven't looked into it, so don't know what would be appropriate). Any pull request doing so would be very welcome!

hannobraun commented 3 years ago

Here's a failing build: https://github.com/stm32-rs/stm32l0xx-hal/runs/2296253088?check_suite_focus=true

dbrgn commented 3 years ago

Regarding the non-uppercase identifiers: I'd suggest silencing these warnings since acronyms are used a lot. Simply applying the fixes might break third party code without any gain.

I'll give it a try.