stm32duino / Arduino_Tools

Contains upload tools for STM32 based boards
Other
87 stars 63 forks source link

Harden shell scripts #56

Closed fpistm closed 4 years ago

fpistm commented 4 years ago
fpistm commented 4 years ago

@kbumsik I've made some change i the run_arduino_gen.sh to be compliant with ShellCheck. I've tested and it works anyway if you can review it and give your feedback, this will be really appreciate. Thanks in advance.

kbumsik commented 4 years ago

@fpistm LGTM, I tested it on my hardware and it works well too. It is interesting that echo -n is not POSIX compliant though.

fpistm commented 4 years ago

Thanks @kbumsik

It is interesting that echo -n is not POSIX compliant though.

Yes it is.