stm32duino / Arduino_Tools

Contains upload tools for STM32 based boards
Other
89 stars 64 forks source link

Fix Java PATH problem on Windows (Fix Issue #67) #68

Closed dadul96 closed 3 years ago

dadul96 commented 4 years ago

This solves the problem where this batch file may use a different Java version compared to the one provided by the Arduino IDE. (see Issue #67)

dadul96 commented 3 years ago

Update

This improved version of the fix enables passing the Arduino IDE installation path to the maple_upload.bat-file in order to always use the correct Java PATH regardless of the Arduino IDE location. This PR only works in combination with the PR in "stm32duino/Arduino_Core_STM32": #1267.

Test/Verification

The whole fix has been verified by me and was also successfully merged into the Arduino_STM32-repository of Roger Clark. (See: merged PR)

fpistm commented 3 years ago

I close this PR as it does not ensure not covered all possible case. Moreover it brings new issue see https://github.com/rogerclarkmelbourne/Arduino_STM32/pull/846