search

stm32duino / ST25R3916

Arduino library that provides an implementation of the NFC RFAL for ST25R3916 component
Other
7 stars 4 forks source link

Add support for the ST25R3916B chip #8

Open amcewen opened 3 weeks ago

amcewen commented 3 weeks ago

The ST25R3916B chip is very similar to the ST25R3916 but not identical. It has a few register changes, etc.

There was a commit that purported to add support for ST25R3916B but it didn't work with the X-NUCLEO-NFC08A1 dev board I was trying. The same code, and library, did work with the X-NUCLEO-NFC06A1 dev board, which uses the ST25R3916 chip.

Digging into the ST sample library that (I assume) this library is based on, there were quite a few changes when they added ST25R3916B support so it would be good to incorporate those here.

amcewen commented 3 weeks ago

I've got a fork which has a first pass, at least, of adding this support.

I haven't tested lots of the functionality in it, but it has had plenty of use reading/writing NTAG213 NFC tags. There might be more work needed for other tags or other bits of functionality but I can submit a PR with what I've got so far if that's useful?

Is there a record anywhere or the specific version of the ST sample library that the original version of this was based on? That would let us diff the two versions and make sure all the changes have been incorporated - I did some diffing, but I don't think the earlier version of the sample library that I'd found was quite the right one, so it was trickier to work out what the changes were.

amcewen commented 3 weeks ago

It also requires some minor changes to NFC-RFAL - I've got a fork of that too, which also adds ESP32 support (which is just a symbol name clash and adding a CMakeLists.txt file). I'll hold off creating an issue in that repo too until there's a PR here to go with it :grinning:

cparata commented 2 weeks ago

Hello @amcewen , the initial support for STM25R3916B chip was done to be compatible with the RFAL version that we already supported in stm32duino (v2.0.10). This is the reason why some features are not implemented for STM25R3916B. Another important point is that the NFC-RFAL library should be compliant with all the ST NFC chips supported (STM25R3916, STM25R3916B, ST25R3911B and ST25R95). Any contribution to improve the library is welcome. So, please, feel free to submit any PR. Best Regards, Carlo