stm32duino / STM32LoRaWAN

Arduino library to support LoRaWAN communication using the STM32WL series.
https://stm32duino.github.io/STM32LoRaWAN/
Other
34 stars 7 forks source link

Add support for RAK3172 module #13

Closed Miceuz closed 1 year ago

Miceuz commented 1 year ago

assume its board description will have GENERIC_WLE5CCUX as a board. Fix #7

Oliv4945 commented 1 year ago

Hello @Miceuz , thanks for this PR but I wonder if another config related to the FR switch should be changed? As per my understanding of this the RAK3172 has an antenna switch with RX/TX_HP but no TX_LP path, so

// Supported TX modes (LP/HP or both)
#if !defined(LORAWAN_TX_CONFIG)
  #define LORAWAN_TX_CONFIG RBI_CONF_RFO_LP_HP
#endif

Should be changed to

// Supported TX modes (LP/HP or both)
#if !defined(LORAWAN_TX_CONFIG)
  #if defined(ARDUINO_NUCLEO_WL55JC1)
    #define LORAWAN_TX_CONFIG RBI_CONF_RFO_LP_HP
  #elif defined(ARDUINO_GENERIC_WLE5CCUX)
    #define LORAWAN_TX_CONFIG RBI_CONF_RFO_HP
  #endif
#endif

This is also probably why you set the same value for LORAWAN_RFSWITCH_RFO_LP_VALUES and LORAWAN_RFSWITCH_RFO_HP_VALUES.

Doing this change actually makes the library work for me

Miceuz commented 1 year ago

@Oliv4945 I don't mind adding this change, but I am not sure about the naming.

Now we are sort of declaring ARDUINO_GENERIC_WLE5CCUX to be RAK3172 - do we want that? This applies both to my previous changes and to the change you are proposing.

fpistm commented 1 year ago

Hi @Miceuz Thanks for this contribution but as stated:

So I close this PR as it will not be merged.