search

stm32duino / VL53L8CX

Arduino library to support the VL53L8CX low-power high-performance 8x8 multizone Time-of-Flight sensor (ToF)
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Add ESP32 to supported architectures? #3

Closed PaulaScharf closed 9 months ago

PaulaScharf commented 9 months ago

Is your feature request/improvement related to a problem? Please describe.

When this library is used on an ESP32 board, there is a warning, that it may be incompatible with this architecture.

Describe the solution you'd like

Add ESP32 to the supported architectures

Additional context

If tried it both on a custom microcontroller with an ESP32S2 processor and an UM Feather S2 board. Both work with this library. Would it be possible to add ESP32 to the supported architectures? The warning is quite confusing, when I show other people sketches that I made with this library.

Or at least it seems to be working. I only tried I2C communication. Are you aware of any shortcomings of this library on ESP32?

fpistm commented 9 months ago

Hi @PaulaScharf We do not have esp32 so we could not test. Library should be 100% Arduino compatible so it probably works if other cores follow Arduino Core API. If you have tested and it works then we could add it to the supported architecture. Do not hesitate to provide a PR for this.

cparata commented 9 months ago

Hi @PaulaScharf , I updated the library properties adding also the support for ESP32. You can download v1.0.3. Best Regards, Carlo

PaulaScharf commented 9 months ago

Nice, thanks for the quick resolve :D