Sorry I had to open another pull request. I've reset the two commits I had in my repo that implemented the old solution.
As we agreed, I've created a new exportable (public) struct called VirtualMediaConfig that can be passed to the new method InsertMediaConfig. Unfortunately Go doesn't support method overloading so another name had to be used. I think that method name should be ok. Tests were implemented as well.
Also I've kept what I did in the previous implementation regarding EjectMedia and avoiding sending no body at all, just sending an empty JSON object to avoid issues with different Redfish implementations.
stmcginnis
commented
3 years ago
Hello Sean,
Sorry I had to open another pull request. I've reset the two commits I had in my repo that implemented the old solution.
As we agreed, I've created a new exportable (public) struct called VirtualMediaConfig that can be passed to the new method InsertMediaConfig. Unfortunately Go doesn't support method overloading so another name had to be used. I think that method name should be ok. Tests were implemented as well.
Also I've kept what I did in the previous implementation regarding EjectMedia and avoiding sending no body at all, just sending an empty JSON object to avoid issues with different Redfish implementations.
Let me know 😄 Best regards!
/Miguel