Closed Sn0rt closed 2 years ago
Thanks @Sn0rt - I think this looks great. The only thing I am concerned about is changing the function signature. There may be existing users of the library that we would break by making that change.
In many (most?) cases, the user will not care about specifying apply time. So can you update this to add a new function call that takes the two arguments? Then the existing call can just call out to that new function with common.OnResetApplyTime
as a default value.
Thanks @Sn0rt - I think this looks great. The only thing I am concerned about is changing the function signature. There may be existing users of the library that we would break by making that change.
In many (most?) cases, the user will not care about specifying apply time. So can you update this to add a new function call that takes the two arguments? Then the existing call can just call out to that new function with
common.OnResetApplyTime
as a default value.
no problem . I will to add new func and the prototype of func is
func (bios *Bios) UpdateBiosAttributesApplyAt (attrs BiosAttributes, applyTime common.ApplyTime) error
what do you think ?
what do you think ?
Sounds great - thanks!
what do you think ?
Sounds great - thanks!
the commmit has been submitted
Sorry, ended up busy yesterday and couldn't get back to this.
I'd like to not duplicate the code, so still think the one should call the other. But I can clean that up later - this looks good.
thank you
In many cases. I think that if
UpdateBiosAttributes
function can pass apply time is easy to use .this case is convert from the DELL bios setting
to set the logger to show the http request of setting as follow
and set the Write to gofish config
Signed-off-by: Guohao Wang wangguohao.2009@gmail.com