search

stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.
BSD 3-Clause "New" or "Revised" License
224 stars 117 forks source link

Support event subscription and submitTestEvent for various vendors #187

Closed nwaizer closed 2 years ago

nwaizer commented 2 years ago

Hi Sean, Thanks again for your help on this.

  1. lint now shows only this: 
    
oem/hpe/hpe.go:8: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
"encoding/json"
redfish/eventdestination.go:10: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
oemZt "github.com/stmcginnis/gofish/oem/zt"
redfish/eventservice.go:9: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
"fmt"

I tried to run goimports -w on these files, to no avail. what to do?
1. Extra files are used in testing the new function as SubscribeZT() and SendEventDell()
2. So you do not want to use a common  CreateEventSubscription() to work for all three oem vendors?
3. Same for not using a common SubmitTestEvent() for all three vendors?
nwaizer commented 2 years ago

all done and ready to merge?