stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.
BSD 3-Clause "New" or "Revised" License
224 stars 117 forks source link

(think twice) bugfix: huawei EffectiveFamily filed is int #220

Closed Sn0rt closed 1 year ago

Sn0rt commented 1 year ago

We need think twice.

Because the following fields have different types of data from different manufacturers.

Because the following fields have different types of data from different manufacturers.

If it is Huawei, the type is int, if it is dell, it is string

Signed-off-by: Sn0rt wangguohao.2009@gmail.com

stmcginnis commented 1 year ago

No, we will not change this to a useless data type for one vendors lack of adhering to the redfish specification. That kind of defeats the purpose of having a standard.

Please open a support ticket with Huawei to have them fix their implementation.

Sn0rt commented 1 year ago

That is, some manufacturers do not comply with the standard implementation, so there must be a way to bypass it. There is no chance of secondary processing due to direct error reporting. It is also possible to provide original information.