search

stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.
BSD 3-Clause "New" or "Revised" License
211 stars 112 forks source link

make concurrency configurable #261

Closed jpiper closed 1 year ago

jpiper commented 1 year ago

This allows the concurrency of HTTP client to be configured (it is 1 by default in order to maintain the existing behaviour). This also has the added benefit that a context cancellation will abort the lock acquisition

stmcginnis commented 1 year ago

Thanks! Any way we can accomplish this without using golang.org/x/sync? I know that library has had some security issues in the past, and I've been trying really hard to keep gofish from needing to pull in any extra dependencies.

jpiper commented 1 year ago

yes I can rewrite this using a simple channel, I'll do that now for you

jpiper commented 1 year ago

I think that does the trick