search

stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.
BSD 3-Clause "New" or "Revised" License
211 stars 112 forks source link

added new parameter MediaType to VirtualMediaConfig #290

Closed Muyk33rus closed 9 months ago

Muyk33rus commented 9 months ago

we need to add a new parameter because without it an error occurs: 400: { "MediaType@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The property MediaType is a required property and must be included in the request.", "MessageArgs": [ "MediaType" ], "MessageId": "Base.1.8.1.PropertyMissing", "MessageSeverity": "Warning", "Resolution": "Ensure that the property is in the request body and has a valid value and resubmit the request if the operation failed." } ] }

Muyk33rus commented 9 months ago

@stmcginnis Can we merge this or are there any problems with this?

stmcginnis commented 9 months ago

Thanks, can you give a little more context on how/where you get this error?

This looks mostly good. The MediaType values are defined in the schema. Can you add that enum?

Muyk33rus commented 9 months ago

We are now testing mounting and unmounting images on the latest versions of https://gerrit.openbmc.org/plugins/gitiles/openbmc/openbmc/ and there just appeared an error when mounting if you do not specify the parameter MediaType.

We already have these enumerations, but why didn’t we use them in the config, I’ll fix it