stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.
BSD 3-Clause "New" or "Revised" License
211 stars 112 forks source link

added the ability to take networkDeviceFunctions, pcieDevices and networkPorts from Controller #301

Closed Muyk33rus closed 4 months ago

Muyk33rus commented 6 months ago

need connect PcieDevice to a network adapter in the current implementation, this task could not be implemented so I had to rewrite the controller class

Now from the Controller we can get Network ports Network functions and PCI devices

ex: { "@odata.context": "/redfish/v1/$metadata#NetworkAdapter.NetworkAdapter", "@odata.etag": "\"1706246633\"", "@odata.id": "/redfish/v1/Chassis/Self/NetworkAdapters/DevType7_NIC1", "@odata.type": "#NetworkAdapter.v1_3_0.NetworkAdapter", "Controllers": [ { "FirmwarePackageVersion": "nil", "Links": { "NetworkDeviceFunctions": [ { "@odata.id": "/redfish/v1/Chassis/Self/NetworkAdapters/DevType7_NIC1/NetworkDeviceFunctions/NetworkDeviceFunction1" } ], "NetworkDeviceFunctions@odata.count": 1, "NetworkPorts": [ { "@odata.id": "/redfish/v1/Chassis/Self/NetworkAdapters/DevType7_NIC1/NetworkPorts/DevType7_DMMY_Instance1_PORT1" } ], "NetworkPorts@odata.count": 1, "PCIeDevices": [ { "@odata.id": "/redfish/v1/Chassis/Self/PCIeDevices/00_01_00" } ], "PCIeDevices@odata.count": 1 } } ], "Id": "DevType7_NIC1", "Name": "DevType7_NIC1", "NetworkDeviceFunctions": { "@odata.id": "/redfish/v1/Chassis/Self/NetworkAdapters/DevType7_NIC1/NetworkDeviceFunctions" }, "NetworkPorts": { "@odata.id": "/redfish/v1/Chassis/Self/NetworkAdapters/DevType7_NIC1/NetworkPorts" }, "Status": { "Health": "OK", "State": "Disabled" } }

stmcginnis commented 4 months ago

I double checked and the object name actually is Controllers, not Controller. So that reinforces my concern that we don't want to change that.

Some of these other things have been picked up with a recent refresh I did to move to the 2023.3 schema release. If anything is missing, please feel free to open a new PR to add them. Thanks for working on this!