make getting Chassis collection work with DPU BMCs

stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.

BSD 3-Clause "New" or "Revised" License

204 stars 109 forks source link

make getting Chassis collection work with DPU BMCs #323

Closed iamsli closed 2 months ago

iamsli commented 2 months ago

This fixes the issue where we cannot get the Chassis collection for DPU BMCs.

Per Redfish docs, Controls should be a Link singular

Controls (v1.17+) { object The link to the collection of controls located in this chassis.
Contains a link to a resource.
@odata.id string read-only Link to Collection of Control. See the Control schema for
details.
}

Closes: #322

stmcginnis commented 2 months ago

Awesome, thanks for fixing it. Would you be able to pick up the other parts of #324? I'll close that one in favor of this PR.

Thanks!

iamsli commented 2 months ago

oh i didn't even see that PR. Just made those changes, thanks!

stmcginnis commented 2 months ago

Thanks!!