Wrong PowerControl argument type on Outlet

stmcginnis / gofish

Gofish is a Golang client library for DMTF Redfish and SNIA Swordfish interaction.

BSD 3-Clause "New" or "Revised" License

204 stars 109 forks source link

Wrong PowerControl argument type on Outlet #339

Closed Arno500 closed 2 months ago

Arno500 commented 2 months ago

Hi there!

Just wanted to raise that the current type used for PowerControl is wrong: it is currently a "PowerState" (from computersystem), but it should be a PowerState from the circuit which should only allow "On", "Off", and "PowerCycle". See:

https://redfish.dmtf.org/schemas/v1/Outlet.v1_4_2.json line 602
Redirecting to https://redfish.dmtf.org/schemas/v1/Circuit.json#/definitions/PowerState line 311

Thanks!

stmcginnis commented 2 months ago

Thanks for pointing that out @Arno500 - good catch! I will update it shortly.