search

stntz / Xamarin.ZoomBinding

Zoom Mobile SDK Binding for Xamarin Android and iOS(device only)
15 stars 13 forks source link

Xamarin Forms 5 breaks this awesome plugin #24

Open gjhdigital opened 3 years ago

gjhdigital commented 3 years ago

I updated my project to XF 5 today and on iOS the MobileRTC is always null now and the app just closes. I havent tested my Android project yet.

public class ZoomService : IZoomService { MobileRTC mobileRTC; MobileRTCAuthService authService;

    public ZoomService()
    {
        mobileRTC = MobileRTC.SharedRTC; // MobileRTC is always Null now
    }

... }

stntz commented 3 years ago

Hi @gjhdigital I am currently looking at migratign to XF 5 in the next 1-2 weeks and will test this out and potentially fix this bug. Is this a major blocker for you?

gjhdigital commented 3 years ago

I actually downgraded my app to XF 4.8 to get it working. Thanks for a great plugin!

Sent from my iPhone

On Feb 13, 2021, at 4:04 PM, stntz notifications@github.com wrote:

 Hi @gjhdigital I am currently looking at migratign to XF 5 in the next 1-2 weeks and will test this out and potentially fix this bug. Is this a major blocker for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

conor-codes commented 3 years ago

@stntz Just wondering what your estimation is on this. I haven't updated to xamarin 5 but I'm assuming it would need to be done also for the Android lib. Thanks

AdamDiament commented 3 years ago

@stntz Hi there. Thanks for your lib. Is this something you are still working on? I have forked the project to attempt to update the zoom android sdk to the latest version (I'm happy to raise a PR back to your repo if I can get it working). I have got the binding projects mobile rtc and common lib building now, after a big fight with the MetaData.xml. I was all set to celebrate, but I am coming across a problem - trying to run the connected xamarin android project leads to a bunch of missing color and style resources. Did you run into this issue creating your original project, and if so how did you solve it? Thanks!

stntz commented 3 years ago

Hi @AdamDiament , thanks for the hard work to get this to build. Yes there were those issues? I had to decompile and recompile using JD-GUI to fix some of those. do you mind sharing a branch and I can take a look at it this evening, been very busy with work lately. apologies to all. will take some time out to look at it now

AdamDiament commented 3 years ago

Hi @AdamDiament , thanks for the hard work to get this to build. Yes there were those issues? I had to decompile and recompile using JD-GUI to fix some of those. do you mind sharing a branch and I can take a look at it this evening, been very busy with work lately. apologies to all. will take some time out to look at it now

Hey @stntz no worries. Thanks for the reply and for taking a look that would be amazing. I raised a PR here https://github.com/stntz/Xamarin.ZoomBinding/pull/28

Basically the two zoom sdk projects build on their own, but trying to build the sample android app results in the errors you can see on the screenshot from my comment here on another issue

I haven't yet successfully tried @GiampaoloGabba's solution to find and replace the variable's in the resources, so that might be a port of call.

Also although the two android aar's are building, this is my first attempt at a binding library, so I'm not totally convinced I've made all the right additions/changes to metadata.xml and the new partial classes I added. I hope what I have done is useful!

stntz commented 3 years ago

Hi @AdamDiament I can confirm I have a working branch to test with, I will figure out how to use git LFS as the sdk is too large, this is Android only at the moment.

AdamDiament commented 3 years ago

@stntz ok great thanks very much. I'm running into some additional build errors with my mobilertc today that weren't there yesterday. I think I didn't properly add the .aar file, as now I'm running into the same LFS issues as you. I've added the v 5.7.6.1918 mobilertc.aar to my local project now but I can't commit or push it. I'm going through the additional build errors now and will push any progress to the same PR I raised yesterday.

stntz commented 3 years ago

Hi @AdamDiament this branch should build for you. xamarin5

AdamDiament commented 3 years ago

@stntz she builds! You're a legend. What would be the process you'd recommend to use in my own app for the time being, until you can make a nuget package available?

Am I right in saying that I would need to build and then reference both the mobilertc.dll and commonlib.dll s in my own android app project?

conor-codes commented 2 years ago

@AdamDiament Did you manage to get this to build? It works fine on android but has a critical error on iOS