AdamDiament
commented
2 years ago Hi @stntz hope you're doing well. Do you have any idea what I did wrong in the recompile stage?
Open AdamDiament opened 2 years ago
AdamDiament
commented
2 years ago Hi @stntz hope you're doing well. Do you have any idea what I did wrong in the recompile stage?
AdamDiament
commented
2 years ago Update - I got all of the placeholders and the recompilation working. I found some more missing placeholders. I used the script here to clean it up. I have raised a ticket with zoom here to fix for future versions.
All of the build failures to do with placeholder strings are fixed. The next problem to overcome is that there are missing resources from the exoplayer dependency. These are likely due to the fact zoom now requires v 2.13.3 of explayer core and UI. The latest xamarin binding is only 2.11. The library has not been updated in 2 years and the maintainer has no intention of continuing support according to the issues. They are awaiting a community contribution.
https://github.com/Baseflow/ExoPlayerXamarin
So we could either get into upgrading the exoplayer binding itself, or investigate a way to bypass these required resources.
AdamDiament
commented
2 years ago The Android project builds now, I have added fake exo resources for now to make this happen - without wanting to embark on a PR into the Exoplayer repo. There are still problems launching on an Android device, due to conflicts with android material versions and Xamarin forms. It is supposed to be fixed with the latest xam 5 support release, but I still get the issue. If you can provide any insight @stntz I would be grateful.
Hi @stntz - I have fixed up all the metadata and the commonlib and mobilertc projects are now building.
I haven't removed any functionality that was already there, and fixed with attr where I could and only used remove-node where absolutely needed.
I upgraded all the dependencies
There is still a problem with the resources not compiling due to the placeholder issue, when trying to build the android sample app. Zoom have fixed the majority but there appear to be some problems left over, in particular strings with both $d and $s in them have not been fixed.
Having said that, I tried to run through the change and recompilation steps, but I keep getting the errors in the xml files even when I think I have fixed all of them, and recompiled the mobilertc.aar file. Either there might be other errors lurking, or I might not be doing the recompilation step properly.
Please could you have a look at this final step for me? I raised an issue on the zoom developer forum, but as we know it might take them 18 months to fix it! I've left the values.xml files as they were, but written down issues I found below.
Values.xml issues I found
zm_accessibility_reacion_label_233717 - %s and %d zm_join_meeting_fail_dialog_msg_164409 - %s and %d zm_alert_remind_archived_content_meeting_267230 - bad whitespace character
Recompilation steps I tried in case I am missing a step you know about:
unzip mobilertc.aar -d tempFolderjar cvf mobilertc.aar -C tempFolder/ .I'm raising this into the xamarin5 branch for now
Thanks!
Adam