stochasticHydroTools / SlenderBody

Slender-body hydrodynamics
11 stars 4 forks source link

Finufft should be a submodule #5

Closed RaulPPelaez closed 1 year ago

RaulPPelaez commented 2 years ago

@omaxian , you should consider making the FINUFFT folder a submodule (as you did with UAMMD_PSE etc). Since you had to modify some files, you should fork finufft (using the stochasticHydroTools name for instance), commit your changes to this new fork and then add that repo as a submodule. As a poor mans alternative, you can add flatiron's finufft repo as a submodule and make the Makefile copy your modified files in there.

I am trying to avoid copy pasting a git repo inside this repo. Which can be trouble for a number of reasons. For instance, you loose access to any bug fixes/improvements that finufft makes in the future (and loose track of the finufft commit you copied). Additionally, it makes tracking your modifications harder, since you cannot use git's machinery easily for that.

Having said that, the code works now, so if you do not find the effort worth you can just close this issue. Best, Raul.