Floating Island coloring, PoD coloring

stochaztic / lttp-tracker

Item tracker for link to the past randomizer

MIT License

10 stars 8 forks source link

Floating Island coloring, PoD coloring #11

Closed miketrethewey closed 6 years ago

miketrethewey commented 6 years ago

TotallyABot on Discord found some issues with coloring of Floating Island and PoD. They supplied this picture.

Floating Island (chest 46) is only accessible by starting in the Dark World by using any of the 3 portals available on LW Death Mountain. The current logic is met by having a glove, hammer and mirror; mirror, pearl and Titan's Mitts. This should still return "glitchavailable" since there's no Lamp in inventory.

PoD has some interesting coloring logic for chests. I was wondering if this accounted for it also being the Palace of Keys and maybe the key requirements wouldn't allow access to more chests without Lamp.

Ninban commented 6 years ago

To summary what I know about PoD:

Without bow, you can be locked after the first chest (item or dungeon item), so it should remain "possible".
With bow, and without lamp, you have access to all but 4 chests (two in dark maze, big chest and boss), meaning a maximum of one item chest is guaranteed is this case, all others being only "available with glitches".

What do you think about it @miketrethewey? My latest PR implements my second point.

EDIT: Just realized lamp block 6 chests, so all 5 items can be lamp-locked. Reverted my PoD changes.

stochaztic commented 6 years ago

With the last two PRs merged does this close all items raised in this issue?

Ninban commented 6 years ago

I actually haven't found anything to change in PoD (so I did a commit reverting a previous one in my PR). However I think the current logic is correct, with lamp blocking 6 chests anyway.

miketrethewey commented 6 years ago

All I knew is that the key placement logic is complicated. If y'all determined that it's accurate to always at most six blocked without Lamp but has the potential to be less based on key placement and that's not something you could know beforehand, I think it's just a caveat that needs to be known about the Palace of Keys. I don't know how to convey that message in a simple manner however.

stochaztic commented 6 years ago

Closing all logic issues due to complete rewrite in #16. If any still exist, please open a new issue.