search

stochaztic / lttp-tracker

Item tracker for link to the past randomizer
MIT License
10 stars 8 forks source link

Support for Inverted mode #26

Closed Bonta0 closed 6 years ago

Bonta0 commented 6 years ago

This adds support for inverted logic Link's house and GT icons are still at their vanilla location, not sure how to fix that 'properly' since it's not really an issue I didnt bother You can test it at https://lttp-tracker-70e14.firebaseapp.com/

stochaztic commented 6 years ago

I haven't been keeping up with Inverted mode logic at all, but can you confirm you've tested both this new mode and the default glitchless mode for a variety of item combinations and everything seems to be operating correctly? Since I don't have the knowledge myself to test if these changes are correct or not, I'm planning to go ahead and merge them once I know there's been testing to ensure the 'normal' use case for the beginner LTTP rando runner is not affected.

Bonta0 commented 6 years ago

I havent had anyone else test it, but done a couple inverted runs myself that worked as expected. Also did some testing for some edge cases (mostly bunny stuff) everything seems fine Regular glitchless logic remains unchanged, no issue there either Would definitely appreciate more feedback though

stochaztic commented 6 years ago

Comments from recitador on the Discord:

light blue means legit obtainable with aga? if so forest hideout, shroom and lj are all incorrectly displaying as available without pearl as is desert ledge, i don't even have the book marked and it's light blue, and if i did have book it should be available via glitch not legit same bug if i have pearl, desert ledge shows light blue without book

As stated I can't evaluate whether these are correct or not, but if you could and either provide a fix if they are truly a problem or let me know if they are not, then I'll pull in and push to prod.

Bonta0 commented 6 years ago

The issue is there is no "agapossible" availability, those items can be seen but not obtained which is why they dont appear as dark blue (glitched). If you mark aga cleared those locations will turn to yellow, which is the desired result ("possible") Should those locations remain that way, mark them unavailable, or use different colors for "agapossible" "glitchagapossible" ? Desert ledge is a good catch, even though it is in logic to enter desert you cant lift the pots to reach the other exit. I have pushed a fix addressing this issue

stochaztic commented 6 years ago

I'm not sure what the best answer is, but I definitely don't think we need another color, it's already pretty information-dense in that regard. In any event, I'll go ahead and merge this now, and keep an eye out for any future PRs that make any more incremental improvements. Thanks for the PR!

Hyphen-ated commented 6 years ago

I'm pretty convinced that "agapossible" locations should be red.

The point of having the light blue aga color is to help answer the question "should I go kill aga now", right? Suppose you have a single non-aga location available, but it's fairly out of the way. If killing aga would open up a ton of locations, you should probably just go kill aga because it's probably required anyway. If killing aga would open up a single location, you might want to go to the non-aga thing first, because aga has a reasonable chance of not being required. The light blue aga color lets you quickly and easily determine which of these situations you're in.

The existence of locations that'll be yellow after you kill aga doesn't seem helpful for making this decision, because they're not in logic yet.

emerald000 commented 6 years ago

"agapossible" are currently red. You can see this in NMG with the bumper cave item. If Kakariko locations are light blue, the bumper item will be red even though you could see it by defeating Agahnim.

stochaztic commented 6 years ago

@Hyphen-ated @emerald000 That sounds correct. If I get a PR from anyone on this thread to fix that issue I'll merge it when possible, but I will be beginning a trip in ~18 hours so my ability to push to prod will be limited after that.

Bonta0 commented 6 years ago

"agapossible" are currently red. You can see this in NMG with the bumper cave item. If Kakariko locations are light blue, the bumper item will be red even though you could see it by defeating Agahnim.

You can't reach bumper ledge without the moonpearl actually, you can only stay in eastern dark world, which is why there is no reference for this

emerald000 commented 6 years ago

You can get there with: Master Sword, Lamp, Moon Pearl, Hammer and Hookshot.